From 46711c9942ebdcf6bbb8472f6893050e48f35f7d Mon Sep 17 00:00:00 2001 From: Valentin Popov Date: Fri, 10 May 2019 15:34:57 +0400 Subject: Added correct test delete record Signed-off-by: Valentin Popov --- tests/api_test.php | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/api_test.php b/tests/api_test.php index 2da6a3d..a2900e4 100644 --- a/tests/api_test.php +++ b/tests/api_test.php @@ -52,6 +52,7 @@ final class local_webhooks_api_testcase extends advanced_testcase { */ private static function get_random_record(): record { $record = new record(); + $record->events = self::get_random_events(); $record->header = 'application/json'; $record->name = uniqid('', false); @@ -102,8 +103,6 @@ final class local_webhooks_api_testcase extends advanced_testcase { /** * Test deletion of the service. * - * @todo It's no testing all conditional. - * * @group local_webhooks * * @throws \dml_exception @@ -115,12 +114,26 @@ final class local_webhooks_api_testcase extends advanced_testcase { $this->resetAfterTest(); + // Testing correct delete record of the database. $record = self::get_random_record(); $record->id = api::add_service($record); self::assertTrue(api::del_service($record->id)); self::assertCount(0, $DB->get_records(LW_TABLE_EVENTS)); self::assertCount(0, $DB->get_records(LW_TABLE_SERVICES)); + + // Testing correct delete record of the record's list. + $ids = []; + $total = random_int(5, 20); + + for ($i = 0; $i < $total; $i++) { + $record = self::get_random_record(); + $ids[] = api::add_service($record); + } + + self::assertEquals(count($ids), api::get_total_count()); + self::assertTrue(api::del_service($ids[array_rand($ids, 1)])); + self::assertEquals(count($ids) - 1, api::get_total_count()); } /** -- cgit v1.2.3