From bde135499d1fe0ca67a1f50fea79848cbdb370ea Mon Sep 17 00:00:00 2001 From: Valentin Popov Date: Mon, 6 May 2019 04:46:09 +0400 Subject: Added a new class for processing events Signed-off-by: Valentin Popov --- classes/task/notify.php | 90 ++++++++++++++++++++++++++++ classes/task/process_events_task.php | 68 --------------------- tests/task_test.php | 111 +++++++++++++++++++++++++++++++++++ 3 files changed, 201 insertions(+), 68 deletions(-) create mode 100644 classes/task/notify.php delete mode 100644 classes/task/process_events_task.php create mode 100644 tests/task_test.php diff --git a/classes/task/notify.php b/classes/task/notify.php new file mode 100644 index 0000000..faa68a9 --- /dev/null +++ b/classes/task/notify.php @@ -0,0 +1,90 @@ +. + +namespace local_webhooks\task; + +defined('MOODLE_INTERNAL') || die(); + +global $CFG; + +require_once($CFG->dirroot . '/local/webhooks/classes/local/api.php'); + +use core\task\adhoc_task; +use curl; +use local_webhooks\local\api; +use local_webhooks\local\record; +use function defined; +use function is_object; +use function is_string; + +/** + * Class for processing events. + * + * @package local_webhooks\task + */ +final class notify extends adhoc_task { + /** + * Debug information. + * + * @var array + */ + public $debug; + + /** + * Process an event. + * + * @throws \dml_exception + */ + public function execute() { + $event = $this->get_custom_data(); + + if (!is_object($event) || !isset($event->eventname) || !is_string($event->eventname)) { + return; + } + + foreach (api::get_services_by_event($event->eventname) as $service) { + if (!is_object($service)) { + continue; + } + + if (!$service->status) { + continue; + } + + $this->post($service, array_merge((array) $event, [ + 'token' => $service->token, + ])); + } + } + + /** + * Send a request for the service. + * + * @param \local_webhooks\local\record $service + * @param array $data + */ + public function post(record $service, array $data) { + $curl = new curl(); + $curl->setHeader(['Content-Type: ' . $service->header]); + $curl->post($service->point, $data); + + if (defined('PHPUNIT_TEST') && PHPUNIT_TEST) { + $this->debug = array_merge($this->debug ?? [], [ + compact('data', 'service'), + ]); + } + } +} \ No newline at end of file diff --git a/classes/task/process_events_task.php b/classes/task/process_events_task.php deleted file mode 100644 index 46f5ea5..0000000 --- a/classes/task/process_events_task.php +++ /dev/null @@ -1,68 +0,0 @@ -. - -/** - * Defining task handlers. - * - * @copyright 2018 'Valentin Popov' - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @package local_webhooks - */ - -namespace local_webhooks\task; - -defined('MOODLE_INTERNAL') || die(); - -global $CFG; - -require_once($CFG->dirroot . '/local/webhooks/lib.php'); - -/** - * Class process_events_task - * - * @copyright 2018 'Valentin Popov' - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @package local_webhooks\task - */ -class process_events_task extends \core\task\adhoc_task { - /** - * Task handler. - * - * @throws \dml_exception - * @throws \moodle_exception - */ - public function execute() { - $services = \local_webhooks_api::get_services_by_event($this->get_custom_data()->eventname); - - foreach ($services as $service) { - if ((bool) $service->status !== true) { - return; - } - - $curl = new \curl(); - - $event = (array) $this->get_custom_data(); - $event['token'] = $service->token; - - $curl->setHeader(array('Content-Type: ' . $service->header)); - $curl->post($service->point, json_encode($event)); - - // TODO: Mark the log. - - $curl->getResponse(); - } - } -} \ No newline at end of file diff --git a/tests/task_test.php b/tests/task_test.php new file mode 100644 index 0000000..dc9d42f --- /dev/null +++ b/tests/task_test.php @@ -0,0 +1,111 @@ +. + +defined('MOODLE_INTERNAL') || die(); + +global $CFG; + +require_once($CFG->dirroot . '/local/webhooks/classes/local/api.php'); + +use core\task\manager; +use local_webhooks\local\api; +use local_webhooks\local\record; +use local_webhooks\task\notify; + +/** + * Class local_webhooks_task_testcase. + * + * @copyright 2019 'Valentin Popov' + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +final class local_webhooks_task_testcase extends advanced_testcase { + /** + * Testing add a task to the queue. + */ + public function test_add_task() { + $this->resetAfterTest(); + + manager::queue_adhoc_task(new notify()); + + $tasks = manager::get_adhoc_tasks('\local_webhooks\task\notify'); + + self::assertCount(1, $tasks); + self::assertInstanceOf('\local_webhooks\task\notify', array_shift($tasks)); + } + + /** + * Testing disabled processing service. + * + * @throws \coding_exception + * @throws \dml_exception + */ + public function test_execute_disabled() { + curl::mock_response('{}'); + $this->resetAfterTest(); + + $record = new record(); + $record->events = ['\core\event\course_viewed']; + $record->header = 'application/json'; + $record->name = 'Example name'; + $record->point = 'http://example.org/'; + $record->status = false; + $record->token = '967b2286-0874-4938-b088-efdbcf8a79bc'; + + $record->id = api::create_service($record); + + $task = new notify(); + $task->set_custom_data(['eventname' => '\core\event\course_viewed']); + $task->execute(); + + self::assertNull($task->debug); + } + + /** + * Testing enabled processing service. + * + * @throws \coding_exception + * @throws \dml_exception + */ + public function test_execute_enabled() { + curl::mock_response('{}'); + $this->resetAfterTest(); + + $record = new record(); + $record->events = ['\core\event\course_viewed']; + $record->header = 'application/json'; + $record->name = 'Example name'; + $record->point = 'http://example.org/'; + $record->status = true; + $record->token = '967b2286-0874-4938-b088-efdbcf8a79bc'; + + $record->id = api::create_service($record); + + $task = new notify(); + $task->set_custom_data(['eventname' => '\core\event\course_viewed']); + $task->execute(); + + self::assertCount(1, $task->debug); + self::assertInternalType('array', $task->debug); + + $element = array_shift($task->debug); + self::assertInternalType('array', $element['data']); + self::assertInternalType('object', $element['service']); + + self::assertEquals($record->events[0], $element['data']['eventname']); + self::assertEquals($record->id, $element['service']->id); + self::assertEquals($record->token, $element['data']['token']); + } +} \ No newline at end of file -- cgit v1.2.3