From d8f3a9f3edf66fad0af84a703e39e45911f37d85 Mon Sep 17 00:00:00 2001 From: Valentin Popov Date: Fri, 2 Nov 2018 00:36:09 +0400 Subject: Formatting code and eliminating possible errors Signed-off-by: Valentin Popov --- classes/event/backup_performed.php | 36 +++++++++++++++++++++++------------- classes/event/backup_restored.php | 36 +++++++++++++++++++++++------------- classes/event/response_answer.php | 34 +++++++++++++++++++++------------- classes/event/service_added.php | 36 +++++++++++++++++++++++------------- classes/event/service_deleted.php | 36 +++++++++++++++++++++++------------- classes/event/service_updated.php | 36 +++++++++++++++++++++++------------- 6 files changed, 136 insertions(+), 78 deletions(-) (limited to 'classes/event') diff --git a/classes/event/backup_performed.php b/classes/event/backup_performed.php index d9a5502..b1f7b7e 100644 --- a/classes/event/backup_performed.php +++ b/classes/event/backup_performed.php @@ -26,40 +26,50 @@ namespace local_webhooks\event; defined('MOODLE_INTERNAL') || die(); +use core\event\base; +use lang_string; +use moodle_url; + /** * Defines how to work with events. * * @copyright 2017 "Valentin Popov" * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -class backup_performed extends \core\event\base { - /** - * Init method. - */ - protected function init() { - $this->data["crud"] = "c"; - $this->data["edulevel"] = self::LEVEL_OTHER; - $this->data["objecttable"] = "local_webhooks_service"; - } - +class backup_performed extends base { /** * Return localised event name. + * + * @throws \coding_exception */ public static function get_name() { - return new \lang_string("create", "moodle"); + return new lang_string('create', 'moodle'); } /** * Returns description of what happened. + * + * @throws \coding_exception */ public function get_description() { - return new \lang_string("backup", "moodle"); + return new lang_string('backup', 'moodle'); } /** * Get URL related to the action. + * + * @throws \moodle_exception */ public function get_url() { - return new \moodle_url("/local/webhooks/index.php"); + return new moodle_url('/local/webhooks/index.php'); + } + + /** + * Init method. + */ + protected function init() { + $this->data['crud'] = 'c'; + $this->data['edulevel'] = self::LEVEL_OTHER; + $this->data['objecttable'] = 'local_webhooks_service'; } } \ No newline at end of file diff --git a/classes/event/backup_restored.php b/classes/event/backup_restored.php index 0b6b5f9..83c9ae6 100644 --- a/classes/event/backup_restored.php +++ b/classes/event/backup_restored.php @@ -26,40 +26,50 @@ namespace local_webhooks\event; defined('MOODLE_INTERNAL') || die(); +use core\event\base; +use lang_string; +use moodle_url; + /** * Defines how to work with events. * * @copyright 2017 "Valentin Popov" * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -class backup_restored extends \core\event\base { - /** - * Init method. - */ - protected function init() { - $this->data["crud"] = "u"; - $this->data["edulevel"] = self::LEVEL_OTHER; - $this->data["objecttable"] = "local_webhooks_service"; - } - +class backup_restored extends base { /** * Return localised event name. + * + * @throws \coding_exception */ public static function get_name() { - return new \lang_string("update", "moodle"); + return new lang_string('update', 'moodle'); } /** * Returns description of what happened. + * + * @throws \coding_exception */ public function get_description() { - return new \lang_string("backupfinished", "moodle"); + return new lang_string('backupfinished', 'moodle'); } /** * Get URL related to the action. + * + * @throws \moodle_exception */ public function get_url() { - return new \moodle_url("/local/webhooks/index.php"); + return new moodle_url('/local/webhooks/index.php'); + } + + /** + * Init method. + */ + protected function init() { + $this->data['crud'] = 'u'; + $this->data['edulevel'] = self::LEVEL_OTHER; + $this->data['objecttable'] = 'local_webhooks_service'; } } \ No newline at end of file diff --git a/classes/event/response_answer.php b/classes/event/response_answer.php index aa12845..95a3949 100644 --- a/classes/event/response_answer.php +++ b/classes/event/response_answer.php @@ -26,40 +26,48 @@ namespace local_webhooks\event; defined('MOODLE_INTERNAL') || die(); +use core\event\base; +use lang_string; +use moodle_url; + /** * Defines how to work with events. * * @copyright 2017 "Valentin Popov" * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -class response_answer extends \core\event\base { - /** - * Init method. - */ - protected function init() { - $this->data["crud"] = "r"; - $this->data["edulevel"] = self::LEVEL_OTHER; - $this->data["objecttable"] = "local_webhooks_service"; - } - +class response_answer extends base { /** * Return localised event name. + * + * @throws \coding_exception */ public static function get_name() { - return new \lang_string("answer", "moodle"); + return new lang_string('answer', 'moodle'); } /** * Returns description of what happened. */ public function get_description() { - return $this->other["status"]; + return $this->other['status']; } /** * Get URL related to the action. + * + * @throws \moodle_exception */ public function get_url() { - return new \moodle_url("/local/webhooks/editservice.php", array("serviceid" => $this->objectid)); + return new moodle_url('/local/webhooks/editservice.php', array('serviceid' => $this->objectid)); + } + + /** + * Init method. + */ + protected function init() { + $this->data['crud'] = 'r'; + $this->data['edulevel'] = self::LEVEL_OTHER; + $this->data['objecttable'] = 'local_webhooks_service'; } } \ No newline at end of file diff --git a/classes/event/service_added.php b/classes/event/service_added.php index 0ec9780..89d7050 100644 --- a/classes/event/service_added.php +++ b/classes/event/service_added.php @@ -26,40 +26,50 @@ namespace local_webhooks\event; defined('MOODLE_INTERNAL') || die(); +use core\event\base; +use lang_string; +use moodle_url; + /** * Defines how to work with events. * * @copyright 2017 "Valentin Popov" * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -class service_added extends \core\event\base { - /** - * Init method. - */ - protected function init() { - $this->data["crud"] = "c"; - $this->data["edulevel"] = self::LEVEL_OTHER; - $this->data["objecttable"] = "local_webhooks_service"; - } - +class service_added extends base { /** * Return localised event name. + * + * @throws \coding_exception */ public static function get_name() { - return new \lang_string("create", "moodle"); + return new lang_string('create', 'moodle'); } /** * Returns description of what happened. + * + * @throws \coding_exception */ public function get_description() { - return new \lang_string("eventwebserviceservicecreated", "webservice"); + return new lang_string('eventwebserviceservicecreated', 'webservice'); } /** * Get URL related to the action. + * + * @throws \moodle_exception */ public function get_url() { - return new \moodle_url("/local/webhooks/editservice.php", array("serviceid" => $this->objectid)); + return new moodle_url('/local/webhooks/editservice.php', array('serviceid' => $this->objectid)); + } + + /** + * Init method. + */ + protected function init() { + $this->data['crud'] = 'c'; + $this->data['edulevel'] = self::LEVEL_OTHER; + $this->data['objecttable'] = 'local_webhooks_service'; } } \ No newline at end of file diff --git a/classes/event/service_deleted.php b/classes/event/service_deleted.php index 4955e55..0d446e7 100644 --- a/classes/event/service_deleted.php +++ b/classes/event/service_deleted.php @@ -26,40 +26,50 @@ namespace local_webhooks\event; defined('MOODLE_INTERNAL') || die(); +use core\event\base; +use lang_string; +use moodle_url; + /** * Defines how to work with events. * * @copyright 2017 "Valentin Popov" * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -class service_deleted extends \core\event\base { - /** - * Init method. - */ - protected function init() { - $this->data["crud"] = "d"; - $this->data["edulevel"] = self::LEVEL_OTHER; - $this->data["objecttable"] = "local_webhooks_service"; - } - +class service_deleted extends base { /** * Return localised event name. + * + * @throws \coding_exception */ public static function get_name() { - return new \lang_string("deleted", "moodle"); + return new lang_string('deleted', 'moodle'); } /** * Returns description of what happened. + * + * @throws \coding_exception */ public function get_description() { - return new \lang_string("eventwebserviceservicedeleted", "webservice"); + return new lang_string('eventwebserviceservicedeleted', 'webservice'); } /** * Get URL related to the action. + * + * @throws \moodle_exception */ public function get_url() { - return new \moodle_url("/local/webhooks/index.php"); + return new moodle_url('/local/webhooks/index.php'); + } + + /** + * Init method. + */ + protected function init() { + $this->data['crud'] = 'd'; + $this->data['edulevel'] = self::LEVEL_OTHER; + $this->data['objecttable'] = 'local_webhooks_service'; } } \ No newline at end of file diff --git a/classes/event/service_updated.php b/classes/event/service_updated.php index 2410d8a..08b7225 100644 --- a/classes/event/service_updated.php +++ b/classes/event/service_updated.php @@ -26,40 +26,50 @@ namespace local_webhooks\event; defined('MOODLE_INTERNAL') || die(); +use core\event\base; +use lang_string; +use moodle_url; + /** * Defines how to work with events. * * @copyright 2017 "Valentin Popov" * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -class service_updated extends \core\event\base { - /** - * Init method. - */ - protected function init() { - $this->data["crud"] = "u"; - $this->data["edulevel"] = self::LEVEL_OTHER; - $this->data["objecttable"] = "local_webhooks_service"; - } - +class service_updated extends base { /** * Return localised event name. + * + * @throws \coding_exception */ public static function get_name() { - return new \lang_string("update", "moodle"); + return new lang_string('update', 'moodle'); } /** * Returns description of what happened. + * + * @throws \coding_exception */ public function get_description() { - return new \lang_string("eventwebserviceserviceupdated", "webservice"); + return new lang_string('eventwebserviceserviceupdated', 'webservice'); } /** * Get URL related to the action. + * + * @throws \moodle_exception */ public function get_url() { - return new \moodle_url("/local/webhooks/editservice.php", array("serviceid" => $this->objectid)); + return new moodle_url('/local/webhooks/editservice.php', array('serviceid' => $this->objectid)); + } + + /** + * Init method. + */ + protected function init() { + $this->data['crud'] = 'u'; + $this->data['edulevel'] = self::LEVEL_OTHER; + $this->data['objecttable'] = 'local_webhooks_service'; } } \ No newline at end of file -- cgit v1.2.3