From d8f3a9f3edf66fad0af84a703e39e45911f37d85 Mon Sep 17 00:00:00 2001
From: Valentin Popov <info@valentineus.link>
Date: Fri, 2 Nov 2018 00:36:09 +0400
Subject: Formatting code and eliminating possible errors

Signed-off-by: Valentin Popov <info@valentineus.link>
---
 classes/service_form.php | 66 +++++++++++++++++++++++++-----------------------
 1 file changed, 35 insertions(+), 31 deletions(-)

(limited to 'classes/service_form.php')

diff --git a/classes/service_form.php b/classes/service_form.php
index 3348247..eac7bb7 100644
--- a/classes/service_form.php
+++ b/classes/service_form.php
@@ -24,7 +24,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->libdir . "/formslib.php");
+require_once($CFG->libdir . '/formslib.php');
 
 /**
  * Description editing form definition.
@@ -42,63 +42,65 @@ class service_edit_form extends moodleform {
 
     /**
      * Defines the standard structure of the form.
+     *
+     * @throws \coding_exception
      */
     protected function definition() {
         $mform =& $this->_form;
-        $size  = array("size" => 60);
+        $size = array('size' => 60);
 
         /* Form heading */
-        $mform->addElement("header", "editserviceheader", new lang_string("service", "webservice"));
+        $mform->addElement('header', 'editserviceheader', new lang_string('service', 'webservice'));
 
         /* Name of the service */
-        $mform->addElement("text", "title", new lang_string("name", "moodle"), $size);
-        $mform->addRule("title", null, "required");
-        $mform->setType("title", PARAM_NOTAGS);
+        $mform->addElement('text', 'title', new lang_string('name', 'moodle'), $size);
+        $mform->addRule('title', null, 'required');
+        $mform->setType('title', PARAM_NOTAGS);
 
         /* Callback address */
-        $mform->addElement("text", "url", new lang_string("url", "moodle"), $size);
-        $mform->addRule("url", null, "required");
-        $mform->setType("url", PARAM_URL);
+        $mform->addElement('text', 'url', new lang_string('url', 'moodle'), $size);
+        $mform->addRule('url', null, 'required');
+        $mform->setType('url', PARAM_URL);
 
         /* Enabling the service */
-        $mform->addElement("advcheckbox", "enable", new lang_string("enable", "moodle"));
-        $mform->setType("enable", PARAM_BOOL);
-        $mform->setDefault("enable", 1);
-        $mform->setAdvanced("enable");
+        $mform->addElement('advcheckbox', 'enable', new lang_string('enable', 'moodle'));
+        $mform->setType('enable', PARAM_BOOL);
+        $mform->setDefault('enable', 1);
+        $mform->setAdvanced('enable');
 
         /* Token */
-        $mform->addElement("text", "token", new lang_string("token", "webservice"), $size);
-        $mform->setType("token", PARAM_NOTAGS);
+        $mform->addElement('text', 'token', new lang_string('token', 'webservice'), $size);
+        $mform->setType('token', PARAM_NOTAGS);
 
         /* Additional information */
-        $mform->addElement("text", "other", new lang_string("sourceext", "plugin"), $size);
-        $mform->setType("other", PARAM_NOTAGS);
-        $mform->setAdvanced("other");
+        $mform->addElement('text', 'other', new lang_string('sourceext', 'plugin'), $size);
+        $mform->setType('other', PARAM_NOTAGS);
+        $mform->setAdvanced('other');
 
         /* Content type */
-        $contenttype = array("json" => "application/json", "x-www-form-urlencoded" => "application/x-www-form-urlencoded");
-        $mform->addElement("select", "type", "Content type", $contenttype);
-        $mform->setAdvanced("type");
+        $contenttype = array('json' => 'application/json', 'x-www-form-urlencoded' => 'application/x-www-form-urlencoded');
+        $mform->addElement('select', 'type', 'Content type', $contenttype);
+        $mform->setAdvanced('type');
 
         /* Form heading */
-        $mform->addElement("header", "editserviceheaderevent", new lang_string("edulevel", "moodle"));
+        $mform->addElement('header', 'editserviceheaderevent', new lang_string('edulevel', 'moodle'));
 
         /* List of events */
-        $eventlist = report_eventlist_list_generator::get_all_events_list(true);
-        $events    = array();
+        $eventlist = report_eventlist_list_generator::get_all_events_list();
+        $events = array();
 
         /* Formation of the list of elements */
         foreach ($eventlist as $event) {
-            $events[$event["component"]][] =& $mform->createElement("checkbox", $event["eventname"], $event["eventname"]);
+            $events[$event['component']][] =& $mform->createElement('checkbox', $event['eventname'], $event['eventname']);
         }
 
         /* Displays groups of items */
         foreach ($events as $key => $event) {
-            $mform->addGroup($event, "events", $key, "<br />", true);
+            $mform->addGroup($event, 'events', $key, '<br />');
         }
 
         /* Control Panel */
-        $this->add_action_buttons(true);
+        $this->add_action_buttons();
     }
 }
 
@@ -118,18 +120,20 @@ class service_backup_form extends moodleform {
 
     /**
      * Defines the standard structure of the form.
+     *
+     * @throws \coding_exception
      */
     protected function definition() {
         $mform =& $this->_form;
 
         /* Form heading */
-        $mform->addElement("header", "editserviceheader", new lang_string("restore", "moodle"));
+        $mform->addElement('header', 'editserviceheader', new lang_string('restore', 'moodle'));
 
         /* Download the file */
-        $mform->addElement("filepicker", "backupfile", new lang_string("file", "moodle"));
-        $mform->addRule("backupfile", null, "required");
+        $mform->addElement('filepicker', 'backupfile', new lang_string('file', 'moodle'));
+        $mform->addRule('backupfile', null, 'required');
 
         /* Control Panel */
-        $this->add_action_buttons(true, new lang_string("restore", "moodle"));
+        $this->add_action_buttons(true, new lang_string('restore', 'moodle'));
     }
 }
\ No newline at end of file
-- 
cgit v1.2.3