From 1352b5ee796c9a9e106cb9746b9201e8038b6210 Mon Sep 17 00:00:00 2001 From: Valentin Popov Date: Mon, 22 Oct 2018 02:17:12 +0400 Subject: Code style fix Signed-off-by: Valentin Popov --- classes/ui_tables_plugin.php | 95 +++++++++++++++++++++++++------------------- 1 file changed, 54 insertions(+), 41 deletions(-) (limited to 'classes/ui_tables_plugin.php') diff --git a/classes/ui_tables_plugin.php b/classes/ui_tables_plugin.php index 7e39598..ecc0c52 100644 --- a/classes/ui_tables_plugin.php +++ b/classes/ui_tables_plugin.php @@ -22,10 +22,10 @@ * @package local_webhooks */ -defined( "MOODLE_INTERNAL" ) || die(); +defined('MOODLE_INTERNAL') || die(); -require_once( $CFG->dirroot . "/local/webhooks/lib.php" ); -require_once( $CFG->libdir . "/tablelib.php" ); +require_once $CFG->dirroot . '/local/webhooks/lib.php'; +require_once $CFG->libdir . '/tablelib.php'; /** * Display the list of services table. @@ -38,20 +38,22 @@ class local_webhooks_services_table extends table_sql { /** * @var string $mainPage */ - protected static $mainPage = "/local/webhooks/index.php"; + protected static $mainPage = '/local/webhooks/index.php'; /** * @var string $editorPage */ - protected static $editorPage = "/local/webhooks/service.php"; + protected static $editorPage = '/local/webhooks/service.php'; /** * Constructor. * * @param string $uniqueId + * + * @throws \coding_exception */ - public function __construct( $uniqueId = "" ) { - parent::__construct( $uniqueId ); + public function __construct($uniqueId = '') { + parent::__construct($uniqueId); $this->define_table_columns(); $this->define_table_configs(); } @@ -59,73 +61,80 @@ class local_webhooks_services_table extends table_sql { /** * Query the database for results to display in the table. * - * @param number $pageSize + * @param int $pageSize * @param boolean $useInitialsBar + * + * @throws \dml_exception */ - public function query_db( $pageSize = 0, $useInitialsBar = false ) { - $this->rawdata = local_webhooks_api::get_services( array(), $this->get_page_start(), $this->get_page_size() ); + public function query_db($pageSize = 0, $useInitialsBar = false) { + $this->rawdata = local_webhooks_api::get_services(array(), $this->get_page_start(), $this->get_page_size()); } /** * Defines the basic settings of the table. */ public function define_table_configs() { - $this->collapsible( false ); - $this->is_downloadable( false ); - $this->no_sorting( "actions" ); - $this->pageable( true ); + $this->collapsible(false); + $this->is_downloadable(false); + $this->no_sorting('actions'); + $this->pageable(true); } /** * Defines the main columns and table headers. + * + * @throws \coding_exception */ public function define_table_columns() { $columns = array( - "name", - "point", - "events", - "actions" + 'name', + 'point', + 'events', + 'actions', ); $headers = array( - new lang_string( "name", "moodle" ), - new lang_string( "url", "moodle" ), - new lang_string( "edulevel", "moodle" ), - new lang_string( "actions", "moodle" ) + new lang_string('name', 'moodle'), + new lang_string('url', 'moodle'), + new lang_string('edulevel', 'moodle'), + new lang_string('actions', 'moodle'), ); - $this->define_columns( $columns ); - $this->define_headers( $headers ); + $this->define_columns($columns); + $this->define_headers($headers); } /** * Specifies the display of a column with actions. * * @param object $row + * * @return string + * @throws \coding_exception + * @throws \moodle_exception */ - public function col_actions( $row ) { + public function col_actions($row) { global $OUTPUT; - $hideShowIcon = "t/show"; - $hideShowString = new lang_string( "enable", "moodle" ); + $hideShowIcon = 't/show'; + $hideShowString = new lang_string('enable', 'moodle'); - if ( !empty( $row->status ) ) { - $hideShowIcon = "t/hide"; - $hideShowString = new lang_string( "disable", "moodle" ); + if (!empty($row->status)) { + $hideShowIcon = 't/hide'; + $hideShowString = new lang_string('disable', 'moodle'); } /* Link for activation / deactivation */ - $hideShowLink = new moodle_url( self::$mainPage, array( "hideshowid" => $row->id, "sesskey" => sesskey() ) ); - $hideShowItem = $OUTPUT->action_icon( $hideShowLink, new pix_icon( $hideShowIcon, $hideShowString ) ); + $hideShowLink = new moodle_url(self::$mainPage, array('hideshowid' => $row->id, 'sesskey' => sesskey())); + $hideShowItem = $OUTPUT->action_icon($hideShowLink, new pix_icon($hideShowIcon, $hideShowString)); /* Link for editing */ - $editLink = new moodle_url( self::$editorPage, array( "serviceid" => $row->id, "sesskey" => sesskey() ) ); - $editItem = $OUTPUT->action_icon( $editLink, new pix_icon( "t/edit", new lang_string( "edit", "moodle" ) ) ); + $editLink = new moodle_url(self::$editorPage, array('serviceid' => $row->id, 'sesskey' => sesskey())); + $editItem = $OUTPUT->action_icon($editLink, new pix_icon('t/edit', new lang_string('edit', 'moodle'))); /* Link to remove */ - $deleteLink = new moodle_url( self::$mainPage, array( "deleteid" => $row->id, "sesskey" => sesskey() ) ); - $deleteItem = $OUTPUT->action_icon( $deleteLink, new pix_icon( "t/delete", new lang_string( "delete", "moodle" ) ) ); + $deleteLink = new moodle_url(self::$mainPage, array('deleteid' => $row->id, 'sesskey' => sesskey())); + $deleteItem = $OUTPUT->action_icon($deleteLink, new pix_icon('t/delete', new lang_string('delete', 'moodle'))); return $hideShowItem . $editItem . $deleteItem; } @@ -134,20 +143,24 @@ class local_webhooks_services_table extends table_sql { * Specifies the display of a column with events. * * @param object $row + * * @return number */ - public function col_events( $row ) { - return count( $row->events ); + public function col_events($row) { + return count($row->events); } /** * Specifies the display of the column with the service name. * * @param object $row + * * @return string + * @throws \moodle_exception */ - public function col_name( $row ) { - $link = new moodle_url( self::$editorPage, array( "serviceid" => $row->id, "sesskey" => sesskey() ) ); - return html_writer::link( $link, $row->name ); + public function col_name($row) { + $link = new moodle_url(self::$editorPage, array('serviceid' => $row->id, 'sesskey' => sesskey())); + + return html_writer::link($link, $row->name); } } \ No newline at end of file -- cgit v1.2.3